use SingleAddressWallet from coreutils #928
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterjan
changed the base branch from
pj/single-address-store
to
its-happening
peterjan
changed the base branch from
its-happening
to
pj/single-address-store
… pj/single-address-wallet
peterjan
force-pushed
the
pj/single-address-wallet
branch
from
825e7b7 to
2aec884
Compare
… pj/single-address-wallet
… pj/single-address-wallet
ChrisSchinnerl
requested changes
Mar 8, 2024
ChrisSchinnerl
approved these changes
Mar 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes our wallet implementation in favour of the one in
coreutils. That has quite some repercussions which is why the PR is lengthy, it's mostly removals though. I left some TODOs but I feel we can safely merge this intoits-happening. If it proves impossible to review I can split it up further, but it's hard to do so and keep the tests 🟢 at the same time.